Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

feat: Update boojum nightly - feature gate packed_simd #46

Merged
merged 6 commits into from
May 22, 2024
Merged

feat: Update boojum nightly - feature gate packed_simd #46

merged 6 commits into from
May 22, 2024

Conversation

mm-zk
Copy link
Contributor

@mm-zk mm-zk commented May 20, 2024 •
edited
Loading

What ❔

  • packed_simd is no longer supported in newest rust nightly
  • added a feature flag (include_packed_simd) to control whether it is included - as it is used for 2 variables EPSILON_VECTOR and EPSILON_VECTOR_D and in other optimized scenarios.
  • updated rust nightly to most recent compiler and cleaned up the warnings.

Why ❔

  • many of the upstream crates start requiring more recent rust versions - and boojum being stuck on version from 2023 started causing compilation issues.

@mm-zk mm-zk requested review from shamatar and dutterbutter May 20, 2024 07:43
@shamatar
Copy link
Member

Maybe just put "nightly" in toolchain.toml?

@mm-zk
Copy link
Contributor Author

mm-zk commented May 21, 2024

@shamatar - done.

@mm-zk
Copy link
Contributor Author

mm-zk commented May 21, 2024

@shamatar - I had to pin it to nightly 2023-05-07 - as the most recent nightly has changed the behavior of flatten.
(I'll fix it in separate PR)

@mm-zk mm-zk merged commit e3a59d5 into main May 22, 2024
4 checks passed
mm-zk added a commit that referenced this pull request May 22, 2024
@mm-zk
Revert "feat: Update boojum nightly - feature gate packed_simd (#46)"
bd424ce 
This reverts commit e3a59d5.
mm-zk added a commit that referenced this pull request May 22, 2024
@mm-zk
Revert "feat: Update boojum nightly - feature gate packed_simd (#46)" (…
be14bfe 
…#48)
mm-zk added a commit that referenced this pull request May 27, 2024
@mm-zk
Revert "Revert "feat: Update boojum nightly - feature gate packed_simd (
6fccabf 
#46)" (#48)"

feat: Update boojum nightly - feature gate packed simd (Attempt 2)

Retries #46
Revert #48

This reverts commit be14bfe.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamatar shamatar shamatar approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mm-zk @shamatar